Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add kind e2e test job for alpha features #29599

Merged
merged 2 commits into from
May 25, 2023
Merged

add kind e2e test job for alpha features #29599

merged 2 commits into from
May 25, 2023

Conversation

jiahuif
Copy link
Member

@jiahuif jiahuif commented May 25, 2023 •
edited
Loading

This PR creates a pull-kubernetes-e2e-kind-alpha-features that is optional and opted-in to ease development of alpha features.

The criteria of alpha feature tests is the [Alpha] label. Usual skips like [Slow], [Disruptive] are preserved. Other settings are copied from pull-kubernetes-e2e-kind job.

Previously, when developing an alpha feature, we borrow the pull-kubernetes-e2e-gce-cos-alpha-features job in ./config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml (example: #26994) . However, adding new feature gate to the list and remove it back later every time a new alpha feature starts is suboptimal. The new job this PR creates formalize the list as "alpha features" and run it with kind to speed things up.

NOTE: usually beta graduation requires E2E tests to be in place, which is why E2E tests for alpha features are rare.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 25, 2023
@k8s-ci-robot k8s-ci-robot requested review from chases2 and wojtek-t May 25, 2023 21:43
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 25, 2023
@BenTheElder
Copy link
Member

cc @aojea @liggitt

@aojea
Copy link
Member

aojea commented May 25, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2023
@BenTheElder
Copy link
Member

/lgtm
/approve
thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, jiahuif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6e61e6a into kubernetes:master May 25, 2023
@k8s-ci-robot
Copy link
Contributor

@jiahuif: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kubernetes-kind-presubmits.yaml using file config/jobs/kubernetes/sig-testing/kubernetes-kind-presubmits.yaml

In response to this:

This PR creates a pull-kubernetes-e2e-kind-alpha-features that is optional and opted-in to ease development of alpha features.

The criteria of alpha feature tests is the [Alpha] label. Usual skips like [Slow], [Disruptive] are preserved. Other settings are copied from pull-kubernetes-e2e-kind job.

Previously, when developing an alpha feature, we borrow the pull-kubernetes-e2e-gce-cos-alpha-features job in ./config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml (example: #26994) . However, adding new feature gate to the list and remove it back later every time a new alpha feature starts is suboptimal. The new job this PR creates formalize the list as "alpha features" and run it with kind to speed things up.

NOTE: usually beta graduation requires E2E tests to be in place, which is why E2E tests for alpha features are rare.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jiahuif jiahuif mentioned this pull request May 25, 2023
Closed
@jiahuif jiahuif deleted the tests/pull-kubernetes-e2e-kind-alpha-features branch May 25, 2023 23:38
@jiahuif jiahuif mentioned this pull request May 26, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chases2 chases2 Awaiting requested review from chases2

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@BenTheElder BenTheElder

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jiahuif @BenTheElder @aojea @k8s-ci-robot